netdev - Re: [PATCH net-next] ptp: don't include ptp_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220107085127.6cfaed55@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 7 Jan 2022 08:51:27 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        vladimir.oltean@....com
Subject: Re: [PATCH net-next] ptp: don't include ptp_clock_kernel.h in spi.h

On Fri, 7 Jan 2022 16:01:33 +0000 Mark Brown wrote:
> On Fri, Jan 07, 2022 at 07:56:45AM -0800, Jakub Kicinski wrote:
> > Commit b42faeee718c ("spi: Add a PTP system timestamp
> > to the transfer structure") added an include of ptp_clock_kernel.h
> > to spi.h for struct ptp_system_timestamp but a forward declaration
> > is enough. Let's use that to limit the number of objects we have
> > to rebuild every time we touch networking headers.  
> 
> Nack, this is a purely SPI patch and should go via SPI (and you've not
> even bothered to fix the subject line).  

Hold off unnecessary comments. If you want me to change something just
tell me rather than making vague references to following "the style for
the subsystem".

> It's already in my queue with that fixed.

What does it mean that it's in "your queue" is, it does not appear in
any branch of
ttps://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/
Will this patch make 5.17?