netdev - Re: [PATCH iproute2 v3 1/2] tc: u32: add support for json output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c6ae652-acbd-3d9c-aa6d-ed338dd04fd7@gmail.com>
Date:   Fri, 7 Jan 2022 09:54:48 -0700
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        Wen Liang <liangwen12year@...il.com>
Cc:     netdev@...r.kernel.org, aclaudi@...hat.com
Subject: Re: [PATCH iproute2 v3 1/2] tc: u32: add support for json output

On 1/6/22 3:30 PM, Stephen Hemminger wrote:
>>  	if (tb[TCA_U32_LINK]) {
>>  		SPRINT_BUF(b1);
>> -		fprintf(f, "link %s ",
>> -			sprint_u32_handle(rta_getattr_u32(tb[TCA_U32_LINK]),
>> +		print_string(PRINT_ANY, "link", "link %s ", sprint_u32_handle(rta_getattr_u32(tb[TCA_U32_LINK]),
>>  					  b1));
> 
> Break that long line up. Would look better with a temporary variable.

+1 and that comment applies to all lines in both patches.