netdev - Re: [RFC PATCH net-next 2/2] net: dsa: remove lockdep class for DSA master address list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <acf49d7b-c502-5b78-dcca-82878e1c4f15@gmail.com>
Date:   Fri, 7 Jan 2022 11:57:19 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: [RFC PATCH net-next 2/2] net: dsa: remove lockdep class for DSA
 master address list

On 1/7/22 10:48 AM, Vladimir Oltean wrote:
> Since commit 2f1e8ea726e9 ("net: dsa: link interfaces with the DSA
> master to get rid of lockdep warnings"), suggested by Cong Wang, the
> DSA interfaces and their master have different dev->nested_level, which
> makes netif_addr_lock() stop complaining about potentially recursive
> locking on the same lock class.
> 
> So we no longer need DSA masters to have their own lockdep class.
> 
> Cc: Cong Wang <xiyou.wangcong@...il.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian