netdev - Re: [PATCH v2 08/35] brcmfmac: of: Fetch Apple properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc93cd06-05c7-fc52-d1bc-3502ae131940@marcan.st>
Date:   Fri, 7 Jan 2022 12:54:39 +0900
From:   Hector Martin <marcan@...can.st>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Chi-hsien Lin <chi-hsien.lin@...ineon.com>,
        Wright Feng <wright.feng@...ineon.com>,
        Dmitry Osipenko <digetx@...il.com>,
        Sven Peter <sven@...npeter.dev>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Mark Kettenis <kettenis@...nbsd.org>,
        Rafał Miłecki <zajec5@...il.com>,
        Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Hans de Goede <hdegoede@...hat.com>,
        "John W. Linville" <linville@...driver.com>,
        "brian m. carlson" <sandals@...stytoothpaste.net>,
        "open list:TI WILINK WIRELES..." <linux-wireless@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" 
        <brcm80211-dev-list.pdl@...adcom.com>,
        SHA-cyfmac-dev-list@...ineon.com
Subject: Re: [PATCH v2 08/35] brcmfmac: of: Fetch Apple properties

On 2022/01/04 20:17, Andy Shevchenko wrote:
> On Tue, Jan 4, 2022 at 9:28 AM Hector Martin <marcan@...can.st> wrote:
>>
>> On Apple ARM64 platforms, firmware selection requires two properties
>> that come from system firmware: the module-instance (aka "island", a
>> codename representing a given hardware platform) and the antenna-sku.
>> We map Apple's module codenames to board_types in the form
>> "apple,<module-instance>".
>>
>> The mapped board_type is added to the DTS file in that form, while the
>> antenna-sku is forwarded by our bootloader from the Apple Device Tree
>> into the FDT. Grab them from the DT so firmware selection can use
>> them.
> 
>> +       /* Apple ARM64 platforms have their own idea of board type, passed in
>> +        * via the device tree. They also have an antenna SKU parameter
>> +        */
>> +       if (!of_property_read_string(np, "brcm,board-type", &prop))
>> +               settings->board_type = devm_kstrdup(dev, prop, GFP_KERNEL);
>> +
>> +       if (!of_property_read_string(np, "apple,antenna-sku", &prop))
>> +               settings->antenna_sku = devm_kstrdup(dev, prop, GFP_KERNEL);
> 
> No error checks?
> But hold on, why do you need to copy them? Are you expecting this to be in DTO?

Yeah, I was wondering about that... indeed it shouldn't be necessary to
copy them.

-- 
Hector Martin (marcan@...can.st)
Public Key: https://mrcn.st/pub