netdev - Re: pull request: bluetooth 2022-01-07

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220107182712.7549a8eb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 7 Jan 2022 18:27:12 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Luiz Augusto von Dentz <luiz.dentz@...il.com>
Cc:     davem@...emloft.net, linux-bluetooth@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: pull request: bluetooth 2022-01-07

On Fri,  7 Jan 2022 13:09:42 -0800 Luiz Augusto von Dentz wrote:
> The following changes since commit 710ad98c363a66a0cd8526465426c5c5f8377ee0:
> 
>   veth: Do not record rx queue hint in veth_xmit (2022-01-06 13:49:54 +0000)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git tags/for-net-next-2022-01-07
> 
> for you to fetch changes up to b9f9dbad0bd1c302d357fdd327c398f51f5fc2b1:
> 
>   Bluetooth: hci_sock: fix endian bug in hci_sock_setsockopt() (2022-01-07 08:41:38 +0100)
> 
> ----------------------------------------------------------------
> bluetooth-next pull request for net-next:
> 
>  - Add support for Foxconn QCA 0xe0d0
>  - Fix HCI init sequence on MacBook Air 8,1 and 8,2
>  - Fix Intel firmware loading on legacy ROM devices

A few warnings here that may be worth addressing - in particular this
one makes me feel that kbuild bot hasn't looked at the patches:

net/bluetooth/hci_sync.c:5143:5: warning: no previous prototype for ‘hci_le_ext_create_conn_sync’ [-Wmissing-prototypes]
 5143 | int hci_le_ext_create_conn_sync(struct hci_dev *hdev, struct hci_conn *conn,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Also this Fixes tag could be mended:

Commit: 6845667146a2 ("Bluetooth: hci_qca: Fix NULL vs IS_ERR_OR_NULL check in qca_serdev_probe")
	Fixes tag: Fixes: 77131dfe ("Bluetooth: hci_qca: Replace devm_gpiod_get() with devm_gpiod_get_optional()")
	Has these problem(s):
		- SHA1 should be at least 12 digits long
		  Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
		  or later) just making sure it is not set (or set to "auto").


Would you be able to fix the new warnings and resend the PR or are you
confident that there isn't much serious breakage here and follow ups
will be enough?

FWIW to see the new warnings check out net-next, do a allmodconfig build
with W=1 C=1, pull in your code, reset back to net-next (this will
"touch" all the files that need rebuilding), do a single threaded build
and save (2>file) the warnings, pull in your code, do another build
(2>file2), diff the warnings from the build of just net-next and after
pull.