lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Jan 2022 19:44:38 -0800 From: Jakub Kicinski <kuba@...nel.org> To: davem@...emloft.net Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, Kees Cook <keescook@...omium.org> Subject: [PATCH net-next] net: allwinner: Fix print format Kees reports quoted commit introduced the following warning on arm64: drivers/net/ethernet/allwinner/sun4i-emac.c:922:60: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=] 922 | netdev_info(ndev, "get io resource from device: 0x%x, size = %u\n", | ~^ | | | unsigned int | %llx 923 | regs->start, resource_size(regs)); | ~~~~~~~~~~~ | | | resource_size_t {aka long long unsigned int} .. and another one like that for resource_size(). Switch to %pa and a cast. Reported-by: Kees Cook <keescook@...omium.org> Fixes: 47869e82c8b8 ("sun4i-emac.c: add dma support") Signed-off-by: Jakub Kicinski <kuba@...nel.org> --- drivers/net/ethernet/allwinner/sun4i-emac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c index 964227e342ee..849de4564709 100644 --- a/drivers/net/ethernet/allwinner/sun4i-emac.c +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c @@ -919,8 +919,8 @@ static int emac_configure_dma(struct emac_board_info *db) goto out_clear_chan; } - netdev_info(ndev, "get io resource from device: 0x%x, size = %u\n", - regs->start, resource_size(regs)); + netdev_info(ndev, "get io resource from device: %pa, size = %u\n", + ®s->start, (unsigned int)resource_size(regs)); db->emac_rx_fifo = regs->start + EMAC_RX_IO_DATA_REG; db->rx_chan = dma_request_chan(&pdev->dev, "rx"); -- 2.31.1
Powered by blists - more mailing lists