lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 8 Jan 2022 21:14:19 +0100
From:   Arend van Spriel <>
To:     Hector Martin <>,
        Kalle Valo <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Rob Herring <>,
        "Rafael J. Wysocki" <>,
        Len Brown <>,
        Arend van Spriel <>,
        Franky Lin <>,
        Hante Meuleman <>,
        Chi-hsien Lin <>,
        Wright Feng <>,
        Dmitry Osipenko <>
Cc:     Sven Peter <>,
        Alyssa Rosenzweig <>,
        Mark Kettenis <>,
        Rafał Miłecki <>,
        Pieter-Paul Giesberts <>,
        Linus Walleij <>,
        Hans de Goede <>,
        "John W. Linville" <>,
        "brian m. carlson" <>,
        Andy Shevchenko <>,,,,,,,
Subject: Re: [PATCH v2 10/35] brcmfmac: firmware: Allow platform to override

On 1/4/2022 8:26 AM, Hector Martin wrote:
> On Device Tree platforms, it is customary to be able to set the MAC
> address via the Device Tree, as it is often stored in system firmware.
> This is particularly relevant for Apple ARM64 platforms, where this
> information comes from system configuration and passed through by the
> bootloader into the DT.
> Implement support for this by fetching the platform MAC address and
> adding or replacing the macaddr= property in nvram. This becomes the
> dongle's default MAC address.
> On platforms with an SROM MAC address, this overrides it. On platforms
> without one, such as Apple ARM64 devices, this is required for the
> firmware to boot (it will fail if it does not have a valid MAC at all).

What overrides what. Can you elaborate a bit?

Reviewed-by: Arend van Spriel <>
> Reviewed-by: Linus Walleij <>
> Signed-off-by: Hector Martin <>
> ---
>   .../broadcom/brcm80211/brcmfmac/firmware.c    | 29 +++++++++++++++++--
>   1 file changed, 27 insertions(+), 2 deletions(-)

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)

Powered by blists - more mailing lists