netdev - Re: [PATCH net-next] gro: add ability to control gro max packet size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56b6d708-b05f-6871-1779-45798a2eccdb@nvidia.com>
Date:   Sun, 9 Jan 2022 16:43:01 +0200
From:   Gal Pressman <gal@...dia.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Coco Li <lixiaoyan@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net-next] gro: add ability to control gro max packet size

On 05/01/2022 12:48, Eric Dumazet wrote:
> From: Coco Li <lixiaoyan@...gle.com>
>
> Eric Dumazet suggested to allow users to modify max GRO packet size.
>
> We have seen GRO being disabled by users of appliances (such as
> wifi access points) because of claimed bufferbloat issues,
> or some work arounds in sch_cake, to split GRO/GSO packets.
>
> Instead of disabling GRO completely, one can chose to limit
> the maximum packet size of GRO packets, depending on their
> latency constraints.
>
> This patch adds a per device gro_max_size attribute
> that can be changed with ip link command.
>
> ip link set dev eth0 gro_max_size 16000
>
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Coco Li <lixiaoyan@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

I wonder if this parameter should apply to HW-GRO as well, I assume it could benefit from that as well?