netdev - Re: [PATCH net-next 3/4] bnxt_en: use firmware provided max timeout for messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220109135841.1cebb7d5@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Sun, 9 Jan 2022 13:58:41 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, gospo@...adcom.com
Subject: Re: [PATCH net-next 3/4] bnxt_en: use firmware provided max timeout
 for messages

On Sat,  8 Jan 2022 20:38:47 -0500 Michael Chan wrote:
> -#define FLASH_NVRAM_TIMEOUT	((HWRM_CMD_TIMEOUT) * 100)
> -#define FLASH_PACKAGE_TIMEOUT	((HWRM_CMD_TIMEOUT) * 200)
> -#define INSTALL_PACKAGE_TIMEOUT	((HWRM_CMD_TIMEOUT) * 200)
> +#define FLASH_NVRAM_TIMEOUT	(bp->hwrm_cmd_max_timeout)
> +#define FLASH_PACKAGE_TIMEOUT	(bp->hwrm_cmd_max_timeout)
> +#define INSTALL_PACKAGE_TIMEOUT	(bp->hwrm_cmd_max_timeout)

> -#define HWRM_COREDUMP_TIMEOUT		((HWRM_CMD_TIMEOUT) * 12)
> +#define HWRM_COREDUMP_TIMEOUT		(bp->hwrm_cmd_max_timeout)

Please don't use variables which are not argument of the macro.
Why not replace the uses?