netdev - Re: [PATCH] iwlwifi: mvm: Use div_s64 instead of do_div in iwl_mvm_ftm_rtt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875yqsvwrd.fsf@kernel.org>
Date:   Mon, 10 Jan 2022 10:08:06 +0200
From:   Kalle Valo <kvalo@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     nathan@...nel.org, johannes.berg@...el.com,
        linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
        luciano.coelho@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH] iwlwifi: mvm: Use div_s64 instead of do_div in iwl_mvm_ftm_rtt_smoothing()

Jakub Kicinski <kuba@...nel.org> writes:

>> When building ARCH=arm allmodconfig:
>> 
>> drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c: In function
>> ‘iwl_mvm_ftm_rtt_smoothing’:
>> ./include/asm-generic/div64.h:222:35: error: comparison of distinct
>> pointer types lacks a cast [-Werror]
>>   222 |         (void)(((typeof((n)) *)0) == ((uint64_t *)0));  \
>>       |                                   ^~
>> drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c:1070:9: note:
>> in expansion of macro ‘do_div’
>>  1070 |         do_div(rtt_avg, 100);
>>       |         ^~~~~~
>
> Let me take this one directly to net-next, hope that's okay.

Thanks, please do, I was offline for a longer period and just came back.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches