lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 10 Jan 2022 10:11:44 +0100
From:   Arend van Spriel <>
To:     Hector Martin <>,
        Kalle Valo <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Rob Herring <>,
        "Rafael J. Wysocki" <>,
        Len Brown <>,
        Arend van Spriel <>,
        Franky Lin <>,
        Hante Meuleman <>,
        Chi-hsien Lin <>,
        Wright Feng <>,
        Dmitry Osipenko <>
Cc:     Sven Peter <>,
        Alyssa Rosenzweig <>,
        Mark Kettenis <>,
        Rafał Miłecki <>,
        Pieter-Paul Giesberts <>,
        Linus Walleij <>,
        Hans de Goede <>,
        "John W. Linville" <>,
        "brian m. carlson" <>,
        Andy Shevchenko <>,,,,,,,
Subject: Re: [PATCH v2 17/35] brcmfmac: pcie: Provide a buffer of random bytes
 to the device

On 1/4/2022 8:26 AM, Hector Martin wrote:
> Newer Apple firmwares on chipsets without a hardware RNG require the
> host to provide a buffer of 256 random bytes to the device on
> initialization. This buffer is present immediately before NVRAM,
> suffixed by a footer containing a magic number and the buffer length.
> This won't affect chips/firmwares that do not use this feature, so do it
> unconditionally.

Not sure what the general opinion is here, but pulling random bytes for 
naught seems wasteful to me. So if there is a way of knowing it is 
needed please make it conditional.

Reviewed-by: Arend van Spriel <>
> Reviewed-by: Linus Walleij <>
> Signed-off-by: Hector Martin <>
> ---
>   .../broadcom/brcm80211/brcmfmac/pcie.c        | 30 +++++++++++++++++++
>   1 file changed, 30 insertions(+)

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)

Powered by blists - more mailing lists