netdev - RE: [Intel-wired-lan] [PATCH v4 net-next 3/9] ice: respect metadata in legacy-rx/ice_construct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB32929E15779B9451D1CE5E98F1509@DM6PR11MB3292.namprd11.prod.outlook.com>
Date:   Mon, 10 Jan 2022 10:16:24 +0000
From:   "Bhandare, KiranX" <kiranx.bhandare@...el.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     Song Liu <songliubraving@...com>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        "Brouer, Jesper" <brouer@...hat.com>, Yonghong Song <yhs@...com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        KP Singh <kpsingh@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Björn Töpel <bjorn@...nel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "Martin KaFai Lau" <kafai@...com>
Subject: RE: [Intel-wired-lan] [PATCH v4 net-next 3/9] ice: respect metadata
 in legacy-rx/ice_construct_skb()


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Alexander Lobakin
> Sent: Wednesday, December 8, 2021 7:37 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Song Liu <songliubraving@...com>; Alexei Starovoitov <ast@...nel.org>;
> Andrii Nakryiko <andrii@...nel.org>; Daniel Borkmann
> <daniel@...earbox.net>; John Fastabend <john.fastabend@...il.com>;
> Jesper Dangaard Brouer <brouer@...hat.com>; Yonghong Song
> <yhs@...com>; Jesper Dangaard Brouer <hawk@...nel.org>; KP Singh
> <kpsingh@...nel.org>; Jakub Kicinski <kuba@...nel.org>;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; David S. Miller
> <davem@...emloft.net>; Björn Töpel <bjorn@...nel.org>;
> bpf@...r.kernel.org; Martin KaFai Lau <kafai@...com>
> Subject: [Intel-wired-lan] [PATCH v4 net-next 3/9] ice: respect metadata in
> legacy-rx/ice_construct_skb()
> 
> In "legacy-rx" mode represented by ice_construct_skb(), we can still use XDP
> (and XDP metadata), but after XDP_PASS the metadata will be lost as it
> doesn't get copied to the skb.
> Copy it along with the frame headers. Account its size on skb allocation, and
> when copying just treat it as a part of the frame and do a pull after to "move"
> it to the "reserved" zone.
> Point net_prefetch() to xdp->data_meta instead of data. This won't change
> anything when the meta is not here, but will save some cache misses
> otherwise.
> 
> Suggested-by: Jesper Dangaard Brouer <brouer@...hat.com>
> Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@...el.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_txrx.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 

Tested-by: Kiran Bhandare <kiranx.bhandare@...el.com>  A Contingent Worker at Intel