netdev - RE: [Intel-wired-lan] [PATCH v3 net-next 2/9] i40e: respect metadata on XSK Rx to skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB32929AFBEAB5A2F42AC17543F1509@DM6PR11MB3292.namprd11.prod.outlook.com>
Date:   Mon, 10 Jan 2022 10:31:26 +0000
From:   "Bhandare, KiranX" <kiranx.bhandare@...el.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     Andre Guedes <andre.guedes@...el.com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Krzysztof Kazimierczak <krzysztof.kazimierczak@...el.com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        John Fastabend <john.fastabend@...il.com>,
        "Alexei Starovoitov" <ast@...nel.org>,
        "Brouer, Jesper" <brouer@...hat.com>,
        Björn Töpel <bjorn@...nel.org>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Vedang Patel <vedang.patel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v3 net-next 2/9] i40e: respect metadata
 on XSK Rx to skb


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Lobakin, Alexandr
> Sent: Wednesday, December 8, 2021 2:25 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Andre Guedes <andre.guedes@...el.com>; Jesper Dangaard Brouer
> <hawk@...nel.org>; Daniel Borkmann <daniel@...earbox.net>;
> netdev@...r.kernel.org; Krzysztof Kazimierczak
> <krzysztof.kazimierczak@...el.com>; bpf@...r.kernel.org; John Fastabend
> <john.fastabend@...il.com>; Alexei Starovoitov <ast@...nel.org>; Brouer,
> Jesper <brouer@...hat.com>; Björn Töpel <bjorn@...nel.org>; Jeff Kirsher
> <jeffrey.t.kirsher@...el.com>; Jakub Kicinski <kuba@...nel.org>; linux-
> kernel@...r.kernel.org; David S. Miller <davem@...emloft.net>; Vedang
> Patel <vedang.patel@...el.com>
> Subject: [Intel-wired-lan] [PATCH v3 net-next 2/9] i40e: respect metadata on
> XSK Rx to skb
> 
> For now, if the XDP prog returns XDP_PASS on XSK, the metadata will be lost
> as it doesn't get copied to the skb.
> Copy it along with the frame headers. Account its size on skb allocation, and
> when copying just treat it as a part of the frame and do a pull after to "move"
> it to the "reserved" zone.
> net_prefetch() xdp->data_meta and align the copy size to speed-up
> memcpy() a little and better match i40e_costruct_skb().
> 
> Fixes: 0a714186d3c0 ("i40e: add AF_XDP zero-copy Rx support")
> Suggested-by: Jesper Dangaard Brouer <brouer@...hat.com>
> Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@...el.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 

Tested-by: Kiran Bhandare <kiranx.bhandare@...el.com>  A Contingent Worker at Intel