lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Jan 2022 13:15:44 +0000 From: Alvin Šipraga <ALSI@...g-olufsen.dk> To: Luiz Angelo Daros de Luca <luizluca@...il.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linus.walleij@...aro.org" <linus.walleij@...aro.org>, "andrew@...n.ch" <andrew@...n.ch>, "vivien.didelot@...il.com" <vivien.didelot@...il.com>, "f.fainelli@...il.com" <f.fainelli@...il.com>, "olteanv@...il.com" <olteanv@...il.com>, "arinc.unal@...nc9.com" <arinc.unal@...nc9.com>, "frank-w@...lic-files.de" <frank-w@...lic-files.de> Subject: Re: [PATCH net-next v4 07/11] net: dsa: realtek: rtl8365mb: rename extport to extint, add "realtek,ext-int" Luiz Angelo Daros de Luca <luizluca@...il.com> writes: > "extport" 0, 1, 2 was used to reference external ports (ext0, > ext1, ext2). Meanwhile, port 0..9 is used as switch ports, > including external ports. "extport" was renamed to extint to > make it clear it does not mean the port number but the external > interface number. > > The macros that map extint numbers to registers addresses now > use inline ifs instead of binary arithmetic. > > "extint" was hardcoded to 1. However, some chips have multiple > external interfaces. It's not right to assume the CPU port uses > extint 1 nor that all extint are CPU ports. Now the association > between the port and the external interface can be defined with > a device-tree port property "realtek,ext-int". > > This patch still does not allow multiple CPU ports nor extint > as a non CPU port. > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com> > Tested-by: Arınç ÜNAL <arinc.unal@...nc9.com> Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk> > --- > drivers/net/dsa/realtek/rtl8365mb.c | 135 ++++++++++++++++++---------- > 1 file changed, 88 insertions(+), 47 deletions(-)
Powered by blists - more mailing lists