netdev - Re: [PATCH net-next] net/mlx5e: Fix build error in fec_set_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220110124212.2190d75c@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 10 Jan 2022 12:42:12 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, saeedm@...dia.com,
        leonro@...dia.com, kernel test robot <lkp@...el.com>,
        Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH net-next] net/mlx5e: Fix build error in
 fec_set_block_stats()

On Mon, 10 Jan 2022 12:33:54 -0800 Saeed Mahameed wrote:
> On Sun, Jan 09, 2022 at 01:33:21PM -0800, Jakub Kicinski wrote:
> >Build bot reports:
> >
> >drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'fec_set_block_stats':
> >drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared (first use in this function); did you mean 'out'?
> >    1235 |         if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
> >         |                                                ^~~~
> >         |                                                out
> >
> >Reported-by: kernel test robot <lkp@...el.com>
> >Suggested-by: Leon Romanovsky <leon@...nel.org>
> >Signed-off-by: Jakub Kicinski <kuba@...nel.org>  
> 
> Thanks For handling ! I have no clue how this happened.
> I will check and improve my process, I Know I've manually changed a patch
> before submission, but i am sure i did it through my normal process.
> 
> Interestingly the series passed netdev/build_allmodconfig_warn.      
> https://patchwork.kernel.org/project/netdevbpf/patch/20220107002956.74849-9-saeed@kernel.org/

And it built just fine for me as well with allmodconfig.

LMK if you figure out why, that's really strange.