netdev - Re: [bnxt] Error: Unable to read VPD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d6ff22c-df69-36c2-4d42-03ed7f539761@gmail.com>
Date:   Tue, 11 Jan 2022 20:41:18 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Michael Chan <michael.chan@...adcom.com>,
        Vijay Balakrishna <vijayb@...ux.microsoft.com>
Cc:     Netdev <netdev@...r.kernel.org>
Subject: Re: [bnxt] Error: Unable to read VPD

On 10.01.2022 22:15, Michael Chan wrote:
> On Mon, Jan 10, 2022 at 1:02 PM Vijay Balakrishna
> <vijayb@...ux.microsoft.com> wrote:
>>
>>
>> Since moving to 5.10 from 5.4 we are seeing
>>
>>> Jan 01 00:00:01 localhost kernel: bnxt_en 0008:01:00.0 (unnamed net_device) (uninitialized): Unable to read VPD
>>>
>>> Jan 01 00:00:01 localhost kernel: bnxt_en 0008:01:00.1 (unnamed net_device) (uninitialized): Unable to read VPD
>>
>> these appear to be harmless and introduced by
>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a0d0fd70fed5cc4f1e2dd98b801be63b07b4d6ac
>> Does "Unable to read VPD" need to be an error or can it be a warning
>> (netdev_warn)?
>>
> 
> We can change these to warnings.  Thanks.

Since 5.15 it is a pci_warn() already. Supposedly "Unable to read VPD" here simply means
that the device has no (valid) VPD. Does "lspci -vv" list any VPD info?
If VPD is an optional feature, then maybe the warning should be changed to info level
and the text should be less alarming.