netdev - RE: [Intel-wired-lan] [PATCH v4 net-next 9/9] ixgbe: respect metadata on XSK Rx to skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW3PR11MB4554E0499E598B382155A48E9C519@MW3PR11MB4554.namprd11.prod.outlook.com>
Date:   Tue, 11 Jan 2022 11:52:12 +0000
From:   "Penigalapati, Sandeep" <sandeep.penigalapati@...el.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     Song Liu <songliubraving@...com>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        "Brouer, Jesper" <brouer@...hat.com>, Yonghong Song <yhs@...com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        KP Singh <kpsingh@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Björn Töpel <bjorn@...nel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "Martin KaFai Lau" <kafai@...com>
Subject: RE: [Intel-wired-lan] [PATCH v4 net-next 9/9] ixgbe: respect metadata
 on XSK Rx to skb

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>Alexander Lobakin
>Sent: Wednesday, December 8, 2021 7:37 PM
>To: intel-wired-lan@...ts.osuosl.org
>Cc: Song Liu <songliubraving@...com>; Alexei Starovoitov <ast@...nel.org>;
>Andrii Nakryiko <andrii@...nel.org>; Daniel Borkmann
><daniel@...earbox.net>; John Fastabend <john.fastabend@...il.com>;
>Jesper Dangaard Brouer <brouer@...hat.com>; Yonghong Song
><yhs@...com>; Jesper Dangaard Brouer <hawk@...nel.org>; KP Singh
><kpsingh@...nel.org>; Jakub Kicinski <kuba@...nel.org>;
>netdev@...r.kernel.org; linux-kernel@...r.kernel.org; David S. Miller
><davem@...emloft.net>; Björn Töpel <bjorn@...nel.org>;
>bpf@...r.kernel.org; Martin KaFai Lau <kafai@...com>
>Subject: [Intel-wired-lan] [PATCH v4 net-next 9/9] ixgbe: respect metadata on
>XSK Rx to skb
>
>For now, if the XDP prog returns XDP_PASS on XSK, the metadata will be lost
>as it doesn't get copied to the skb.
>Copy it along with the frame headers. Account its size on skb allocation, and
>when copying just treat it as a part of the frame and do a pull after to "move"
>it to the "reserved" zone.
>net_prefetch() xdp->data_meta and align the copy size to speed-up
>memcpy() a little and better match ixgbe_costruct_skb().
>
>Fixes: d0bcacd0a130 ("ixgbe: add AF_XDP zero-copy Rx support")
>Suggested-by: Jesper Dangaard Brouer <brouer@...hat.com>
>Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>Signed-off-by: Alexander Lobakin <alexandr.lobakin@...el.com>
>Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
>---
> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@...el.com>