netdev - Re: [PATCH v2 2/5] can: rcar_canfd: Add support for r8a779a0 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1933768449.3343335.1642092286817@webmail.strato.com>
Date:   Thu, 13 Jan 2022 17:44:46 +0100 (CET)
From:   Ulrich Hecht <uli@...nd.eu>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org,
        davem@...emloft.net, linux-can@...r.kernel.org,
        prabhakar.mahadev-lad.rj@...renesas.com,
        biju.das.jz@...renesas.com, wsa@...nel.org,
        yoshihiro.shimoda.uh@...esas.com, wg@...ndegger.com,
        kuba@...nel.org, mailhol.vincent@...adoo.fr,
        socketcan@...tkopp.net, geert@...ux-m68k.org,
        kieran.bingham@...asonboard.com
Subject: Re: [PATCH v2 2/5] can: rcar_canfd: Add support for r8a779a0 SoC


> On 01/12/2022 7:43 PM Marc Kleine-Budde <mkl@...gutronix.de> wrote:
> > +#define IS_V3U (gpriv->chip_id == RENESAS_R8A779A0)
> 
> I really don't like this macro, as it silently relies on gpriv....and
> I really don't like this use of this macro in the other macros that lead
> to 2 or even 3 ternary operators hiding inside them. Is there any chance
> to change this?

Good point. I guess I should turn that into a function.

CU
Uli