lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Jan 2022 17:57:12 +0000 From: "G, GurucharanX" <gurucharanx.g@...el.com> To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "David S. Miller" <davem@...emloft.net>, "Jakub Kicinski" <kuba@...nel.org> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, Christoph Hellwig <hch@....de> Subject: RE: [Intel-wired-lan] [PATCH] ixgbe: Remove useless DMA-32 fallback configuration > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of > Christophe JAILLET > Sent: Sunday, January 9, 2022 10:51 PM > To: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L > <anthony.l.nguyen@...el.com>; David S. Miller <davem@...emloft.net>; > Jakub Kicinski <kuba@...nel.org> > Cc: netdev@...r.kernel.org; kernel-janitors@...r.kernel.org; linux- > kernel@...r.kernel.org; Christophe JAILLET > <christophe.jaillet@...adoo.fr>; intel-wired-lan@...ts.osuosl.org; Christoph > Hellwig <hch@....de> > Subject: [Intel-wired-lan] [PATCH] ixgbe: Remove useless DMA-32 fallback > configuration > > As stated in [1], dma_set_mask() with a 64-bit mask never fails if > dev->dma_mask is non-NULL. > So, if it fails, the 32 bits case will also fail for the same reason. > > So, if dma_set_mask_and_coherent() succeeds, 'pci_using_dac' is known to > be 1. > > Simplify code and remove some dead code accordingly. > > [1]: https://lkml.org/lkml/2021/6/7/398 > > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > Reviewed-by: Christoph Hellwig <hch@....de> > Reviewed-by: Alexander Lobakin <alexandr.lobakin@...el.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 20 +++++++------------ > 1 file changed, 7 insertions(+), 13 deletions(-) > Tested-by: Gurucharan G <gurucharanx.g@...el.com> (A Contingent worker at Intel)
Powered by blists - more mailing lists