lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Jan 2022 17:03:39 +0100 From: Loic Poulain <loic.poulain@...aro.org> To: Slark Xiao <slark_xiao@....com> Cc: ryazanov.s.a@...il.com, johannes@...solutions.net, davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Shujun Wang <wsj20369@....com> Subject: Re: [PATCH] Fix MRU mismatch issue which may lead to data connection lost On Fri, 14 Jan 2022 at 11:07, Slark Xiao <slark_xiao@....com> wrote: > > In pci_generic.c there is a 'mru_default' in struct mhi_pci_dev_info. > This value shall be used for whole mhi if it's given a value for a specific product. > But in function mhi_net_rx_refill_work(), it's still using hard code value MHI_DEFAULT_MRU. > 'mru_default' shall have higher priority than MHI_DEFAULT_MRU. > And after checking, this change could help fix a data connection lost issue. Interesting, not sure why it fixes data issues, since the device should comply with any size.Can you add a Fixes tag then? and add the correct [PATCH net] suffix in the subject: https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html With that: Reviewed-by: Loic Poulain <loic.poulain@...aro.org> Thanks, Loic > > Signed-off-by: Shujun Wang <wsj20369@....com> > Signed-off-by: Slark Xiao <slark_xiao@....com> > --- > drivers/net/wwan/mhi_wwan_mbim.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c > index 71bf9b4f769f..6872782e8dd8 100644 > --- a/drivers/net/wwan/mhi_wwan_mbim.c > +++ b/drivers/net/wwan/mhi_wwan_mbim.c > @@ -385,13 +385,13 @@ static void mhi_net_rx_refill_work(struct work_struct *work) > int err; > > while (!mhi_queue_is_full(mdev, DMA_FROM_DEVICE)) { > - struct sk_buff *skb = alloc_skb(MHI_DEFAULT_MRU, GFP_KERNEL); > + struct sk_buff *skb = alloc_skb(mbim->mru, GFP_KERNEL); > > if (unlikely(!skb)) > break; > > err = mhi_queue_skb(mdev, DMA_FROM_DEVICE, skb, > - MHI_DEFAULT_MRU, MHI_EOT); > + mbim->mru, MHI_EOT); > if (unlikely(err)) { > kfree_skb(skb); > break; > -- > 2.25.1 >
Powered by blists - more mailing lists