lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YeGqFq2oJqIzar53@calimero.vinschen.de> Date: Fri, 14 Jan 2022 17:51:34 +0100 From: Corinna Vinschen <vinschen@...hat.com> To: Denis Kirjanov <dkirjanov@...e.de> Cc: intel-wired-lan@...osl.org, netdev@...r.kernel.org, Vinicius Costa Gomes <vinicius.gomes@...el.com>, Lennert Buytenhek <buytenh@...tstofly.org>, Alexander Lobakin <alexandr.lobakin@...el.com> Subject: Re: [PATCH 2/2 net-next v2] igb: refactor XDP registration On Jan 14 17:13, Denis Kirjanov wrote: > 1/14/22 14:43, Corinna Vinschen пишет: > > On changing the RX ring parameters igb uses a hack to avoid a warning > > when calling xdp_rxq_info_reg via igb_setup_rx_resources. It just > > clears the struct xdp_rxq_info content. > > > > Change this to unregister if we're already registered instead. ALign > > code to the igc code. > > > > Fixes: 9cbc948b5a20c ("igb: add XDP support") > > Signed-off-by: Corinna Vinschen <vinschen@...hat.com> > > --- > > drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ---- > > drivers/net/ethernet/intel/igb/igb_main.c | 15 +++++++++++---- > > 2 files changed, 11 insertions(+), 8 deletions(-) > > [...] > > + if (res < 0) { > > + netdev_err(rx_ring->netdev, > > + "Failed to register xdp_rxq index %u\n", > > + rx_ring->queue_index); > nit: would be nice to have the same printing functions like dev_err() > in the error case Thanks, I pushed a v3. Corinna
Powered by blists - more mailing lists