lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Jan 2022 20:55:07 +0300 From: Sergey Shtylyov <s.shtylyov@....ru> To: Florian Fainelli <f.fainelli@...il.com>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Mark Brown <broonie@...nel.org> CC: Andrew Lunn <andrew@...n.ch>, Ulf Hansson <ulf.hansson@...aro.org>, Vignesh Raghavendra <vigneshr@...com>, KVM list <kvm@...r.kernel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, <linux-iio@...r.kernel.org>, "Linus Walleij" <linus.walleij@...aro.org>, Amit Kucheria <amitk@...nel.org>, "ALSA Development Mailing List" <alsa-devel@...a-project.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Jaroslav Kysela <perex@...ex.cz>, Guenter Roeck <groeck@...omium.org>, Thierry Reding <thierry.reding@...il.com>, MTD Maling List <linux-mtd@...ts.infradead.org>, Linux I2C <linux-i2c@...r.kernel.org>, Miquel Raynal <miquel.raynal@...tlin.com>, <linux-phy@...ts.infradead.org>, Jiri Slaby <jirislaby@...nel.org>, <openipmi-developer@...ts.sourceforge.net>, "David S. Miller" <davem@...emloft.net>, Khuong Dinh <khuong@...amperecomputing.com>, Matthias Schiffer <matthias.schiffer@...tq-group.com>, Joakim Zhang <qiangqing.zhang@....com>, Kamal Dasu <kdasu.kdev@...il.com>, Lee Jones <lee.jones@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Daniel Lezcano <daniel.lezcano@...aro.org>, Kishon Vijay Abraham I <kishon@...com>, "Geert Uytterhoeven" <geert@...ux-m68k.org>, "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>, Zhang Rui <rui.zhang@...el.com>, Linux PWM List <linux-pwm@...r.kernel.org>, Robert Richter <rric@...nel.org>, Saravanan Sekar <sravanhome@...il.com>, Corey Minyard <minyard@....org>, Linux PM list <linux-pm@...r.kernel.org>, Liam Girdwood <lgirdwood@...il.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, John Garry <john.garry@...wei.com>, Peter Korsgaard <peter@...sgaard.com>, "William Breathitt Gray" <vilhelm.gray@...il.com>, Mark Gross <markgross@...nel.org>, Hans de Goede <hdegoede@...hat.com>, Alex Williamson <alex.williamson@...hat.com>, Tony Luck <tony.luck@...el.com>, "Borislav Petkov" <bp@...en8.de>, Sebastian Reichel <sre@...nel.org>, Jakub Kicinski <kuba@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, Takashi Iwai <tiwai@...e.com>, <platform-driver-x86@...r.kernel.org>, Benson Leung <bleung@...omium.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, <linux-edac@...r.kernel.org>, Mun Yew Tham <mun.yew.tham@...el.com>, "Eric Auger" <eric.auger@...hat.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, Cornelia Huck <cohuck@...hat.com>, "Linux MMC List" <linux-mmc@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-spi <linux-spi@...r.kernel.org>, Linux-Renesas <linux-renesas-soc@...r.kernel.org>, Vinod Koul <vkoul@...nel.org>, James Morse <james.morse@....com>, Zha Qipeng <qipeng.zha@...el.com>, Pengutronix Kernel Team <kernel@...gutronix.de>, Richard Weinberger <richard@....at>, Niklas Söderlund <niklas.soderlund@...natech.se>, <linux-mediatek@...ts.infradead.org>, "Brian Norris" <computersforpeace@...il.com>, <netdev@...r.kernel.org> Subject: Re: [PATCH] driver core: platform: Rename platform_get_irq_optional() to platform_get_irq_silent() On 1/14/22 12:42 AM, Florian Fainelli wrote: >> The subsystems regulator, clk and gpio have the concept of a dummy >> resource. For regulator, clk and gpio there is a semantic difference >> between the regular _get() function and the _get_optional() variant. >> (One might return the dummy resource, the other won't. Unfortunately >> which one implements which isn't the same for these three.) The >> difference between platform_get_irq() and platform_get_irq_optional() is >> only that the former might emit an error message and the later won't. >> >> To prevent people's expectations that there is a semantic difference >> between these too, rename platform_get_irq_optional() to >> platform_get_irq_silent() to make the actual difference more obvious. >> >> The #define for the old name can and should be removed once all patches >> currently in flux still relying on platform_get_irq_optional() are >> fixed. >> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> [...] >>>> I think at least c) is easy to resolve because >>>> platform_get_irq_optional() isn't that old yet and mechanically >>>> replacing it by platform_get_irq_silent() should be easy and safe. >>>> And this is orthogonal to the discussion if -ENOXIO is a sensible return >>>> value and if it's as easy as it could be to work with errors on irq >>>> lookups. >>> >>> It'd certainly be good to name anything that doesn't correspond to one >>> of the existing semantics for the API (!) something different rather >>> than adding yet another potentially overloaded meaning. >> >> It seems we're (at least) three who agree about this. Here is a patch >> fixing the name. > > From an API naming perspective this does not make much sense anymore with the name chosen, > it is understood that whent he function is called platform_get_irq_optional(), optional applies > to the IRQ. An optional IRQ is something people can reason about because it makes sense. Right! :-) > What is a a "silent" IRQ however? It does not apply to the object it is trying to fetch to > anymore, but to the message that may not be printed in case the resource failed to be obtained, > because said resource is optional. Woah, that's quite a stretch. Right again! :-) > Following the discussion and original 2 patches set from Sergey, it is not entirely clear to me > anymore what is it that we are trying to fix. Andy and me tried to fix the platform_get_irq[_byname]_optional() value, corresponding to a missing (optional) IRQ resource from -ENXIO to 0, in order to keep the callers error code agnostic. This change completely aligns e.g. platform_get_irq_optional() with clk_get_optional() and gpiod_get_optional()... Unforunately, we can't "fix" request_irq() and company to treat 0 as missing IRQ -- they have to keep the ability to get called from the arch/ code (that doesn't use platform_get_irq(), etc. > I nearly forgot, I would paint it blue, sky blue, not navy blue, not light blue ;) :-) PS: Florian, something was wrong with your mail client -- I had to manually wrap your quotes, else there were super long unbroken paragraphs...
Powered by blists - more mailing lists