netdev - Re: [PATCH v21 bpf-next 18/23] libbpf: Add SEC name for xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC1LvL3M9OaSanES0uzp=vvgK23qPGRPpcAR6Z_Vqcvma3K5Qg@mail.gmail.com>
Date:   Fri, 14 Jan 2022 10:55:24 -0800
From:   Zvi Effron <zeffron@...tgames.com>
To:     Jesper Dangaard Brouer <jbrouer@...hat.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>, brouer@...hat.com,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Lorenzo Bianconi <lorenzo.bianconi@...hat.com>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Shay Agroskin <shayagr@...zon.com>,
        john fastabend <john.fastabend@...il.com>,
        David Ahern <dsahern@...nel.org>,
        Eelco Chaudron <echaudro@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Saeed Mahameed <saeed@...nel.org>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        tirthendu.sarkar@...el.com
Subject: Re: [PATCH v21 bpf-next 18/23] libbpf: Add SEC name for xdp_mb programs

On Fri, Jan 14, 2022 at 8:50 AM Jesper Dangaard Brouer
<jbrouer@...hat.com> wrote:
>
>
>
> On 14/01/2022 03.09, Alexei Starovoitov wrote:
> > On Thu, Jan 13, 2022 at 3:58 PM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
> >>>
> >>> Btw "xdp_cpumap" should be cleaned up.
> >>> xdp_cpumap is an attach type. It's not prog type.
> >>> Probably it should be "xdp/cpumap" to align with "cgroup/bind[46]" ?
> >>
> >> so for xdp "mb" or xdp "frags" it will be xdp/cpumap.mb (xdp/devmap.mb) or
> >> xdp/cpumap.frags (xdp/devmap.frags), right?
> >
> > xdp.frags/cpumap
> > xdp.frags/devmap
> >
> > The current de-facto standard for SEC("") in libbpf:
> > prog_type.prog_flags/attach_place
>
> Ups, did we make a mistake with SEC("xdp_devmap/")
>
> and can we correct without breaking existing programs?
>

We can (at the very least) add the correct sections, even if we leave the
current incorrect ones as well. Ideally we'd mark the incorrect ones deprecated
and either remove them before libbpf 1.0 or as part of 2.0?

--Zvi

> > "attach_place" is either function_name for fentry/, tp/, lsm/, etc.
> > or attach_type/hook/target for cgroup/bind4, cgroup_skb/egress.
> >
> > lsm.s/socket_bind -> prog_type = LSM, flags = SLEEPABLE
> > lsm/socket_bind -> prog_type = LSM, non sleepable.
> >
>