netdev - Re: [PATCH net] net: wwan: Fix MRU mismatch issue which may lead to data connection lost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 15 Jan 2022 15:18:06 +0100
From:   Loic Poulain <loic.poulain@...aro.org>
To:     Slark Xiao <slark_xiao@....com>
Cc:     Shujun Wang <wsj20369@....com>, davem@...emloft.net,
        johannes@...solutions.net, kuba@...nel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        ryazanov.s.a@...il.com
Subject: Re: [PATCH net] net: wwan: Fix MRU mismatch issue which may lead to
 data connection lost

Le sam. 15 janv. 2022 à 03:35, Slark Xiao <slark_xiao@....com> a écrit :
>
> In pci_generic.c there is a 'mru_default' in struct mhi_pci_dev_info.
> This value shall be used for whole mhi if it's given a value for a specific product.
> But in function mhi_net_rx_refill_work(), it's still using hard code value MHI_DEFAULT_MRU.
> 'mru_default' shall have higher priority than MHI_DEFAULT_MRU.
> And after checking, this change could help fix a data connection lost issue.
>
> Fixes: 5c2c85315948 ("bus: mhi: pci-generic: configurable network interface MRU")
> Signed-off-by: Shujun Wang <wsj20369@....com>
> Signed-off-by: Slark Xiao <slark_xiao@....com>
> ---

Reviewed-by: Loic Poulain <loic.poulain@...aro.org>