netdev - Re: [PATCH net v2] bonding: Fix extraction of ports from the packet headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3153.1642364617@famine>
Date:   Sun, 16 Jan 2022 12:23:37 -0800
From:   Jay Vosburgh <jay.vosburgh@...onical.com>
To:     Moshe Tal <moshet@...dia.com>
cc:     Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Jussi Maki <joamaki@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Tariq Toukan <tariqt@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Gal Pressman <gal@...dia.com>
Subject: Re: [PATCH net v2] bonding: Fix extraction of ports from the packet headers

Moshe Tal <moshet@...dia.com> wrote:

>Wrong hash sends single stream to multiple output interfaces.
>
>The offset calculation was relative to skb->head, fix it to be relative
>to skb->data.
>
>Fixes: a815bde56b15 ("net, bonding: Refactor bond_xmit_hash for use with
>xdp_buff")
>Reviewed-by: Jussi Maki <joamaki@...il.com>
>Reviewed-by: Saeed Mahameed <saeedm@...dia.com>
>Reviewed-by: Gal Pressman <gal@...dia.com>
>Signed-off-by: Moshe Tal <moshet@...dia.com>

Acked-by: Jay Vosburgh <jay.vosburgh@...onical.com>

>---
>
>Notes:
>    v2: Change the offset to be relative to skb->data in higher level to
>    handle the case when skb is NULL.
>
> drivers/net/bonding/bond_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index fce80b57f15b..ec498ce70f35 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -3874,8 +3874,8 @@ u32 bond_xmit_hash(struct bonding *bond, struct sk_buff *skb)
> 	    skb->l4_hash)
> 		return skb->hash;
> 
>-	return __bond_xmit_hash(bond, skb, skb->head, skb->protocol,
>-				skb->mac_header, skb->network_header,
>+	return __bond_xmit_hash(bond, skb, skb->data, skb->protocol,
>+				skb_mac_offset(skb), skb_network_offset(skb),
> 				skb_headlen(skb));
> }
> 
>-- 
>2.26.2
>