lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <776c385c-84f8-4716-8561-52f60463e202@marcan.st> Date: Mon, 17 Jan 2022 15:58:20 +0900 From: Hector Martin <marcan@...can.st> To: Arend van Spriel <arend.vanspriel@...adcom.com>, Kalle Valo <kvalo@...eaurora.org>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Rob Herring <robh+dt@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, Arend van Spriel <aspriel@...il.com>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, Chi-hsien Lin <chi-hsien.lin@...ineon.com>, Wright Feng <wright.feng@...ineon.com>, Dmitry Osipenko <digetx@...il.com> Cc: Sven Peter <sven@...npeter.dev>, Alyssa Rosenzweig <alyssa@...enzweig.io>, Mark Kettenis <kettenis@...nbsd.org>, Rafał Miłecki <zajec5@...il.com>, Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>, Linus Walleij <linus.walleij@...aro.org>, Hans de Goede <hdegoede@...hat.com>, "John W. Linville" <linville@...driver.com>, "brian m. carlson" <sandals@...stytoothpaste.net>, Andy Shevchenko <andy.shevchenko@...il.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, brcm80211-dev-list.pdl@...adcom.com, SHA-cyfmac-dev-list@...ineon.com Subject: Re: [PATCH v2 23/35] brcmfmac: cfg80211: Add support for scan params v2 On 11/01/2022 17.50, Arend van Spriel wrote: > On 1/4/2022 8:26 AM, Hector Martin wrote: >> This new API version is required for at least the BCM4387 firmware. Add >> support for it, with a fallback to the v1 API. > > Reviewed-by: Arend van Spriel <arend.vanspriel@...adcom.com> >> Acked-by: Linus Walleij <linus.walleij@...aro.org> >> Signed-off-by: Hector Martin <marcan@...can.st> >> --- >> .../broadcom/brcm80211/brcmfmac/cfg80211.c | 113 ++++++++++++++---- >> .../broadcom/brcm80211/brcmfmac/feature.c | 1 + >> .../broadcom/brcm80211/brcmfmac/feature.h | 4 +- >> .../broadcom/brcm80211/brcmfmac/fwil_types.h | 49 +++++++- >> 4 files changed, 145 insertions(+), 22 deletions(-) >> >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c >> index fb727778312c..71e932a8302c 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c >> @@ -769,12 +769,50 @@ void brcmf_set_mpc(struct brcmf_if *ifp, int mpc) >> } >> } >> >> +static void brcmf_escan_prep(struct brcmf_cfg80211_info *cfg, >> + struct brcmf_scan_params_v2_le *params_le, >> + struct cfg80211_scan_request *request); > > I am not a fan of function prototypes so if it can be avoided by simply > moving the function that would be preferred over this. Moved the function for v3 :) >> + if (!brcmf_feat_is_enabled(ifp, BRCMF_FEAT_SCAN_V2)) { > > Okay. So it is not really a fallback. Phew! I meant fallback in case the feature is not present, not fallback from trying to use it without checking. Thankfully we can use a feature test for this :-) -- Hector Martin (marcan@...can.st) Public Key: https://mrcn.st/pub
Powered by blists - more mailing lists