netdev - Re: [PATCH] ath9k_htc: fix uninit value bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Jan 2022 21:35:13 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Kalle Valo <kvalo@...nel.org>
Cc:     ath9k-devel@....qualcomm.com, kvalo@...eaurora.org,
        davem@...emloft.net, kuba@...nel.org, linville@...driver.com,
        vasanth@...eros.com, Sujith.Manoharan@...eros.com,
        senthilkumar@...eros.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+f83a1df1ed4f67e8d8ad@...kaller.appspotmail.com
Subject: Re: [PATCH] ath9k_htc: fix uninit value bugs

Hi Kalle,

On 1/17/22 15:57, Kalle Valo wrote:
>> Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
>> Reported-by: syzbot+f83a1df1ed4f67e8d8ad@...kaller.appspotmail.com
>> Signed-off-by: Pavel Skripkin <paskripkin@...il.com>
> 
> How did you test this? As syzbot is mentioned I assume you did not test this on
> a real device, it would help a lot if this is clearly mentioned in the commit
> log. My trust on syzbot fixes is close to zero due to bad past history.
> 

You are right, I've tested only with syzbot's reproducer. I've followed 
simple guess: if code works properly with random values in these fields 
for 14+ years, then zeroing them won't hurt much.

I might be missing something, but unfortunately I don't have suitable hw 
piece to test the change.




With regards,
Pavel Skripkin