netdev - Re: [PATCH v1 1/2] xfrm: Check if_id in xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Jan 2022 12:46:31 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Yan Yan <evitayan@...gle.com>
CC:     <netdev@...r.kernel.org>, Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Lorenzo Colitti" <lorenzo@...gle.com>,
        Maciej Żenczykowski <maze@...gle.com>,
        Nathan Harold <nharold@...gle.com>,
        Benedict Wong <benedictwong@...gle.com>
Subject: Re: [PATCH v1 1/2] xfrm: Check if_id in xfrm_migrate

Hi Yan,

On Wed, Jan 12, 2022 at 02:53:31PM -0800, Yan Yan wrote:
> Hi Steffen,
> 
> The Jan 7th patch fixes the following warning (reported by the kernel
> test robot) by adding parentheses.
>    net/xfrm/xfrm_policy.c: In function 'xfrm_migrate':
> >> net/xfrm/xfrm_policy.c:4403:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
>     4403 |                 if (x = xfrm_migrate_state_find(mp, net, if_id)) {
>          |                     ^
> 
> In the Jan 7th patch, this line becomes "if ((x =
> xfrm_migrate_state_find(mp, net, if_id))) {"

I thought that was already fixed in the previous version.
Please mark updated patches as v2 etc. and describe the
changes you did in the new version.

Please resend your patchset and add a proper 'Fixes:'
tag to the patches.

Thanks!