lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <d8c5c288-2890-c62b-1cb3-3b81319f1ee6@gmail.com> Date: Sun, 16 Jan 2022 19:46:46 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Luiz Angelo Daros de Luca <luizluca@...il.com>, netdev@...r.kernel.org Cc: linus.walleij@...aro.org, andrew@...n.ch, vivien.didelot@...il.com, olteanv@...il.com, alsi@...g-olufsen.dk, arinc.unal@...nc9.com, frank-w@...lic-files.de Subject: Re: [PATCH net-next v4 03/11] net: dsa: realtek: remove direct calls to realtek-smi On 1/4/2022 7:15 PM, Luiz Angelo Daros de Luca wrote: > Remove the only two direct calls from subdrivers to realtek-smi. > Now they are called from realtek_priv. Subdrivers can now be > linked independently from realtek-smi. > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com> > --- [snip] Just a nit below. > return 0; > @@ -1705,7 +1707,7 @@ static int rtl8366rb_reset_chip(struct realtek_priv *priv) > u32 val; > int ret; > > - realtek_smi_write_reg_noack(priv, RTL8366RB_RESET_CTRL_REG, > + priv->write_reg_noack(priv, RTL8366RB_RESET_CTRL_REG, > RTL8366RB_CHIP_CTRL_RESET_HW); Only if you need to spin a new version, the second line should start at the character after the opening parenthesis on the previous line. Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists