netdev - Re: [PATCH iproute2 v4 1/2] tc: u32: add support for json output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220117203044.0950e959@hermes.local>
Date:   Mon, 17 Jan 2022 20:30:44 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Wen Liang <liangwen12year@...il.com>
Cc:     netdev@...r.kernel.org, dsahern@...il.com, aclaudi@...hat.com
Subject: Re: [PATCH iproute2 v4 1/2] tc: u32: add support for json output

On Mon, 17 Jan 2022 21:42:20 -0500
Wen Liang <liangwen12year@...il.com> wrote:

> Currently u32 filter output does not support json. This commit uses
> proper json functions to add support for it.
> 
> Signed-off-by: Wen Liang <liangwen12year@...il.com>

Minor warnings from checkpatch, please fix:

WARNING: Missing a blank line after declarations
#88: FILE: tc/f_u32.c:1231:
+		__u32 htdivisor = rta_getattr_u32(tb[TCA_U32_DIVISOR]);
+		print_int(PRINT_ANY, "ht_divisor", "ht divisor %d ", htdivisor);

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: tc/f_u32.c:1250:
+		char *link = sprint_u32_handle(rta_getattr_u32(tb[TCA_U32_LINK]),b1);
 		                                                                ^

WARNING: Missing a blank line after declarations
#115: FILE: tc/f_u32.c:1251:
+		char *link = sprint_u32_handle(rta_getattr_u32(tb[TCA_U32_LINK]),b1);
+		print_string(PRINT_ANY, "link", "link %s ", link);

WARNING: Missing a blank line after declarations
#202: FILE: tc/f_u32.c:1323:
+			unsigned int hmask = (unsigned int)htonl(sel->hmask);
+			print_hex(PRINT_ANY, "hash_mask", "    hash mask %08x ", hmask);

total: 1 errors, 3 warnings, 151 lines checked