netdev - Re: [PATCH v3] tcp: Use BPF timeout setting for SYN ACK RTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <26CE358E-1A2F-4971-B455-9100142830BE@yandex-team.ru>
Date:   Tue, 18 Jan 2022 20:07:40 +0300
From:   Akhmat Karakotov <hmukos@...dex-team.ru>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Martin KaFai Lau <kafai@...com>, Lawrence Brakmo <brakmo@...com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Alexander Azimov <mitradir@...dex-team.ru>,
        Neal Cardwell <ncardwell@...gle.com>, netdev@...r.kernel.org,
        Yuchung Cheng <ycheng@...gle.com>, zeil@...dex-team.ru,
        davem@...emloft.net
Subject: Re: [PATCH v3] tcp: Use BPF timeout setting for SYN ACK RTO

On Jan 18, 2022, at 20:04, Jakub Kicinski <kuba@...nel.org> wrote:
> 
> On Tue, 18 Jan 2022 19:49:49 +0300 Akhmat Karakotov wrote:
>> On Jan 18, 2022, at 18:57, Jakub Kicinski <kuba@...nel.org> wrote:
>>> 
>>> On Mon, 17 Jan 2022 18:26:45 +0300 Akhmat Karakotov wrote:  
>>>> We got the patch acked couple of weeks ago, please let us know what
>>>> further steps are required before merge.  
>>> 
>>> Did you post a v4 addressing Yuchung's request?  
>> 
>> I thought that Yuchung suggested to make a separate refactor patch?
> 
> Unclear whether separate patch implies separate "series" there.
> 
>>> but that can be done by a later refactor patch  
>> 
>> But if necessary I will integrate those changes in this patch with v4.
> 
> Right, net-next is closed, anyway, v4 as a 2-patch mini-series may be
> the best way.

Why separate then if the second patch is just a refactor? Wouldn't single patch be simpler and better?