netdev - Re: [PATCH iproute2 v4 1/2] tc: u32: add support for json output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49be1ddc-2c7d-1b7f-795a-30612433e83a@gmail.com>
Date:   Tue, 18 Jan 2022 13:04:50 -0700
From:   David Ahern <dsahern@...il.com>
To:     Wen Liang <liangwen12year@...il.com>, netdev@...r.kernel.org
Cc:     stephen@...workplumber.org, aclaudi@...hat.com
Subject: Re: [PATCH iproute2 v4 1/2] tc: u32: add support for json output

On 1/17/22 7:42 PM, Wen Liang wrote:
> diff --git a/tc/f_u32.c b/tc/f_u32.c
> index a5747f67..03dbe774 100644
> --- a/tc/f_u32.c
> +++ b/tc/f_u32.c
> @@ -1213,11 +1213,11 @@ static int u32_print_opt(struct filter_util *qu, FILE *f, struct rtattr *opt,
>  
>  	if (handle) {
>  		SPRINT_BUF(b1);
> -		fprintf(f, "fh %s ", sprint_u32_handle(handle, b1));
> +		print_string(PRINT_ANY, "fh", "fh %s ", sprint_u32_handle(handle, b1));

sprint_u32_handle adds a space after the raw check. I think that space
can be removed.

Also, seems like raw and json should be incompatible.