netdev - Re: [PATCH] net: fix fragments have the disallowed options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220118131006.083f8b23@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 18 Jan 2022 13:10:06 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     ooppublic@....com
Cc:     davem@...emloft.net, dsahern@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: fix fragments have the disallowed options

On Wed, 12 Jan 2022 10:43:24 -0800 Jakub Kicinski wrote:
> On Fri,  7 Jan 2022 16:05:59 +0800 ooppublic@....com wrote:
> > From: caixf <ooppublic@....com>
> > 
> > When in function ip_do_fragment() enter fsat path,  
> 
> fsat -> fast
> 
> > if skb have opthons, all fragments will have the same options.  
> 
> opthons -> options
> 
> > Just guarantee the second fragment not have the disallowed options.  
> 
> You're right. Can you send a patch which explicitly reverts these
> two commits instead:
> 
>  1b9fbe813016b08e08b22ddba4ddbf9cb1b04b00
>  faf482ca196a5b16007190529b3b2dd32ab3f761
> 
> I prefer the code the way it was before them, plus keeping the code how
> it was could help backports.

Please let us know if you're planning to send the new patch otherwise
I'll do the revert myself, it's a clear bug.