netdev - Re: [PATCH v22 bpf-next 17/23] bpf: selftests: update xdp_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJr8wC0hnwkKyqegf+byovzPPTzHNYK7jyckMpw7vHHHw@mail.gmail.com>
Date:   Tue, 18 Jan 2022 14:30:05 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Lorenzo Bianconi <lorenzo.bianconi@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Shay Agroskin <shayagr@...zon.com>,
        John Fastabend <john.fastabend@...il.com>,
        David Ahern <dsahern@...nel.org>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Eelco Chaudron <echaudro@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Saeed Mahameed <saeed@...nel.org>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        tirthendu.sarkar@...el.com,
        Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH v22 bpf-next 17/23] bpf: selftests: update xdp_adjust_tail
 selftest to include multi-frags

On Tue, Jan 18, 2022 at 2:23 PM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>
> > On Mon, Jan 17, 2022 at 06:28:29PM +0100, Lorenzo Bianconi wrote:
> > > +
> > > +   CHECK(err || retval != XDP_TX || size != exp_size,
> > > +         "9k-10b", "err %d errno %d retval %d[%d] size %d[%u]\n",
> > > +         err, errno, retval, XDP_TX, size, exp_size);
> > ...
> > > +   CHECK(err || retval != XDP_TX || size != exp_size,
> > > +         "9k-1p", "err %d errno %d retval %d[%d] size %d[%u]\n",
> > > +         err, errno, retval, XDP_TX, size, exp_size);
> > ...
> > > +   CHECK(err || retval != XDP_TX || size != exp_size,
> > > +         "9k-2p", "err %d errno %d retval %d[%d] size %d[%u]\n",
> > > +         err, errno, retval, XDP_TX, size, exp_size);
> >
> > CHECK is deprecated.
> > That nit was mentioned many times. Please address it in all patches.
>
> I kept the CHECK macro because there were other CHECK occurrences in
> xdp_adjust_tail.c (e.g. in test_xdp_adjust_tail_grow()).
> I guess we can add a preliminary patch to convert the other CHECK
> occurrences used in xdp_adjust_tail.c (the same for xdp_bpf2bpf.c).
> What do you think?

Please do.