netdev - Re: [PATCH 1/2] platform: make platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 19 Jan 2022 14:42:09 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrew Lunn <andrew@...n.ch>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Vignesh Raghavendra <vigneshr@...com>, <kvm@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        <linux-iio@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        <alsa-devel@...a-project.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Joakim Zhang <qiangqing.zhang@....com>,
        Guenter Roeck <groeck@...omium.org>,
        Thierry Reding <thierry.reding@...il.com>,
        <linux-mtd@...ts.infradead.org>, <linux-i2c@...r.kernel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        <linux-phy@...ts.infradead.org>, <linux-spi@...r.kernel.org>,
        Lee Jones <lee.jones@...aro.org>,
        <openipmi-developer@...ts.sourceforge.net>,
        "Khuong Dinh" <khuong@...amperecomputing.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        Kamal Dasu <kdasu.kdev@...il.com>,
        "Jiri Slaby" <jirislaby@...nel.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        "Daniel Lezcano" <daniel.lezcano@...aro.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        <bcm-kernel-feedback-list@...adcom.com>,
        <linux-serial@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        "Jaroslav Kysela" <perex@...ex.cz>, <linux-pwm@...r.kernel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Robert Richter <rric@...nel.org>,
        Saravanan Sekar <sravanhome@...il.com>,
        Corey Minyard <minyard@....org>, <linux-pm@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "John Garry" <john.garry@...wei.com>,
        Peter Korsgaard <peter@...sgaard.com>,
        "William Breathitt Gray" <vilhelm.gray@...il.com>,
        Mark Gross <markgross@...nel.org>,
        <linux-gpio@...r.kernel.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Mark Brown <broonie@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        "Sebastian Reichel" <sre@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "Takashi Iwai" <tiwai@...e.com>,
        <platform-driver-x86@...r.kernel.org>,
        Benson Leung <bleung@...omium.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-edac@...r.kernel.org>, Tony Luck <tony.luck@...el.com>,
        Mun Yew Tham <mun.yew.tham@...el.com>,
        Eric Auger <eric.auger@...hat.com>, <netdev@...r.kernel.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Cornelia Huck <cohuck@...hat.com>, <linux-mmc@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-renesas-soc@...r.kernel.org>,
        "Vinod Koul" <vkoul@...nel.org>, James Morse <james.morse@....com>,
        Zha Qipeng <qipeng.zha@...el.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Richard Weinberger <richard@....at>,
        Niklas Söderlund <niklas.soderlund@...natech.se>,
        <linux-mediatek@...ts.infradead.org>,
        "Brian Norris" <computersforpeace@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional
 (summary)

On 1/19/22 2:33 PM, Uwe Kleine-König wrote:

[...]
>>>>> A possible compromise: We can have both. We rename
>>>>> platform_get_irq_optional() to platform_get_irq_silent() (or
>>>>> platform_get_irq_silently() if this is preferred) and once all users are
>>>>> are changed (which can be done mechanically), we reintroduce a
>>>>> platform_get_irq_optional() with Sergey's suggested semantic (i.e.
>>>>> return 0 on not-found, no error message printking).
>>>>
>>>> Please do not do that as anyone trying to forward-port an old driver
>>>> will miss the abi change of functionality and get confused.  Make
>>>> build-breaking changes, if the way a function currently works is
>>>> changed in order to give people a chance.
>>>
>>> Fine for me. I assume this is a Nack for Sergey's patch?
>>
>>    Which patch do you mean? I'm starting to get really muddled... :-(
> 
> I'm talking about "[PATCH 1/2] platform: make
> platform_get_irq_optional() optional"

   I thought GregKH was talking about your renaming patch... :-/

> because "trying to forward-port an
> old driver will miss the abi" applies to it.

   Mhm... why not tell me right from the start? Jr even tell that to Andy
instead of merging his patch, so I wouldn't get sucked into this work? 
I wouldn't bother with v2 and it would have saved a lot of time spent on
email... :-(
   Do we also remember that "the stable API is a nonsense" thing? :-)

> Best regards
> Uwe

MBR, Sergey