lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Jan 2022 10:06:35 -0500 From: Steven Rostedt <rostedt@...dmis.org> To: Sakari Ailus <sakari.ailus@...ux.intel.com> Cc: Lucas De Marchi <lucas.demarchi@...el.com>, linux-kernel@...r.kernel.org, intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org, linux-security-module@...r.kernel.org, nouveau@...ts.freedesktop.org, netdev@...r.kernel.org, Alex Deucher <alexander.deucher@....com>, Andrew Morton <akpm@...ux-foundation.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Andy Shevchenko <andy.shevchenko@...il.com>, Ben Skeggs <bskeggs@...hat.com>, Christian König <christian.koenig@....com>, Chris Wilson <chris@...is-wilson.co.uk>, Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...ux.ie>, "David S . Miller" <davem@...emloft.net>, Emma Anholt <emma@...olt.net>, Eryk Brol <eryk.brol@....com>, Francis Laniel <laniel_francis@...vacyrequired.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Harry Wentland <harry.wentland@....com>, Jakub Kicinski <kuba@...nel.org>, Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Julia Lawall <julia.lawall@...6.fr>, Kentaro Takeda <takedakn@...data.co.jp>, Leo Li <sunpeng.li@....com>, Mikita Lipski <mikita.lipski@....com>, Petr Mladek <pmladek@...e.com>, Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>, Raju Rangoju <rajur@...lsio.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Sergey Senozhatsky <sergey.senozhatsky@...il.com>, Vishal Kulkarni <vishal@...lsio.com> Subject: Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation On Wed, 19 Jan 2022 11:18:59 +0200 Sakari Ailus <sakari.ailus@...ux.intel.com> wrote: > On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, > > case 3: > > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) > > tomoyo_io_printf(head, " grant_log=%s", > > - tomoyo_yesno(cond->grant_log == > > - TOMOYO_GRANTLOG_YES)); > > + yesno(cond->grant_log == TOMOYO_GRANTLOG_YES)); > > This would be better split on two lines. Really? Yuck! I thought the "max line size" guideline was going to grow to a 100, but I still see it as 80. But anyway... cond->grant_log == TOMOYO_GRANTLOG_YES is not readable at all. Not compared to cond->grant_log == TOMOYO_GRANTLOG_YES I say keep it one line! Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org> -- Steve > > Then, > > Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
Powered by blists - more mailing lists