netdev - Re: [PATCH] net/ipv6: remove redundant err variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220119075927.0d2c4a21@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Wed, 19 Jan 2022 07:59:27 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     cgel.zte@...il.com
Cc:     chi.minghao@....com.cn, davem@...emloft.net, dsahern@...il.com,
        dsahern@...nel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org, zealci@....com.cn
Subject: Re: [PATCH] net/ipv6: remove redundant err variable

On Wed, 19 Jan 2022 05:55:57 +0000 cgel.zte@...il.com wrote:
> There are more than 3,000 numbers retrieved by the rules I wrote.
> Of course, many of these 3,000 are false positives, and maybe 
> there are 300 patches.I wrote this rule similar to returnvar.cocci.

Can you start by improving returnvar.cocci so it catches all the cases?
Then make sure your patches build and don't introduce formatting
problems. Then post them.