lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Jan 2022 21:29:28 +0300 From: Sergey Shtylyov <s.shtylyov@....ru> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, "Geert Uytterhoeven" <geert@...ux-m68k.org> CC: Andrew Lunn <andrew@...n.ch>, Ulf Hansson <ulf.hansson@...aro.org>, Vignesh Raghavendra <vigneshr@...com>, KVM list <kvm@...r.kernel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, <linux-iio@...r.kernel.org>, "Linus Walleij" <linus.walleij@...aro.org>, Amit Kucheria <amitk@...nel.org>, "ALSA Development Mailing List" <alsa-devel@...a-project.org>, Jaroslav Kysela <perex@...ex.cz>, Guenter Roeck <groeck@...omium.org>, Thierry Reding <thierry.reding@...il.com>, MTD Maling List <linux-mtd@...ts.infradead.org>, Linux I2C <linux-i2c@...r.kernel.org>, Miquel Raynal <miquel.raynal@...tlin.com>, <linux-phy@...ts.infradead.org>, linux-spi <linux-spi@...r.kernel.org>, Jiri Slaby <jirislaby@...nel.org>, "David S. Miller" <davem@...emloft.net>, Khuong Dinh <khuong@...amperecomputing.com>, Florian Fainelli <f.fainelli@...il.com>, Matthias Schiffer <matthias.schiffer@...tq-group.com>, Kamal Dasu <kdasu.kdev@...il.com>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, Lee Jones <lee.jones@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Daniel Lezcano <daniel.lezcano@...aro.org>, Kishon Vijay Abraham I <kishon@...com>, bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>, "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>, Zhang Rui <rui.zhang@...el.com>, <platform-driver-x86@...r.kernel.org>, Linux PWM List <linux-pwm@...r.kernel.org>, Robert Richter <rric@...nel.org>, "Saravanan Sekar" <sravanhome@...il.com>, Corey Minyard <minyard@....org>, Linux PM list <linux-pm@...r.kernel.org>, Liam Girdwood <lgirdwood@...il.com>, "Mauro Carvalho Chehab" <mchehab@...nel.org>, John Garry <john.garry@...wei.com>, Peter Korsgaard <peter@...sgaard.com>, William Breathitt Gray <vilhelm.gray@...il.com>, Mark Gross <markgross@...nel.org>, Hans de Goede <hdegoede@...hat.com>, Alex Williamson <alex.williamson@...hat.com>, "Mark Brown" <broonie@...nel.org>, Borislav Petkov <bp@...en8.de>, Takashi Iwai <tiwai@...e.com>, Matthias Brugger <matthias.bgg@...il.com>, <openipmi-developer@...ts.sourceforge.net>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Benson Leung <bleung@...omium.org>, Pengutronix Kernel Team <kernel@...gutronix.de>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, <linux-edac@...r.kernel.org>, "Tony Luck" <tony.luck@...el.com>, Richard Weinberger <richard@....at>, Mun Yew Tham <mun.yew.tham@...el.com>, Eric Auger <eric.auger@...hat.com>, netdev <netdev@...r.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, Cornelia Huck <cohuck@...hat.com>, "Linux MMC List" <linux-mmc@...r.kernel.org>, Joakim Zhang <qiangqing.zhang@....com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux-Renesas <linux-renesas-soc@...r.kernel.org>, Vinod Koul <vkoul@...nel.org>, "James Morse" <james.morse@....com>, Zha Qipeng <qipeng.zha@...el.com>, "Sebastian Reichel" <sre@...nel.org>, Niklas Söderlund <niklas.soderlund@...natech.se>, <linux-mediatek@...ts.infradead.org>, "Brian Norris" <computersforpeace@...il.com>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional On 1/19/22 7:12 PM, Sergey Shtylyov wrote: [...] >>> So there's still a need for two functions. >> >> Or a single function not emitting an error message together with the >> callers being responsible for calling dev_err(). >> >> So the options in my preference order (first is best) are: >> >> - Remove the printk from platform_get_irq() and remove >> platform_get_irq_optional(); > > Strong NAK here: > - dev_err() in our function saves a lot of (repeatable!) comments; s/comments/code/. Actually, I think I can accept the removal of dev_err_probe() in platform_get_irq() as this is not a common practice anyway (yet? :-))... > - we've already discussed that it's more optimal to check againt 0 than Against. :-) > against -ENXIO in the callers. And we also aim to be the error code agnostic in the callers... >> - Rename platform_get_irq_optional() to platform_get_irq_silently() > > NAK as well. We'd better off complaining about irq < 0 in this function. >> - Keep platform_get_irq_optional() as is > > NAK, it's suboptimal in the call sites. s/in/on/. [...] >> Best regards >> Uwe MBR, Sergey
Powered by blists - more mailing lists