netdev - Re: Empty return from bond_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABWYdi3SEvO0yLS7vxiXBufoTBy5ZZzQoBeoSU2wQeSa-snnwA@mail.gmail.com>
Date:   Tue, 18 Jan 2022 18:04:56 -0800
From:   Ivan Babrou <ivan@...udflare.com>
To:     Jay Vosburgh <jay.vosburgh@...onical.com>
Cc:     Jussi Maki <joamaki@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        kernel-team <kernel-team@...udflare.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Moshe Tal <moshet@...dia.com>
Subject: Re: Empty return from bond_eth_hash in 5.15

On Tue, Jan 18, 2022 at 4:15 PM Ivan Babrou <ivan@...udflare.com> wrote:
> > commit 429e3d123d9a50cc9882402e40e0ac912d88cfcf (HEAD -> master, origin/master, origin/HEAD)
> > Author: Moshe Tal <moshet@...dia.com>
> > Date:   Sun Jan 16 19:39:29 2022 +0200
> >
> >     bonding: Fix extraction of ports from the packet headers
> >
> >     Wrong hash sends single stream to multiple output interfaces.
> >
> >         which was just committed to net a few days ago; are you in a
> > position that you'd be able to test this change?
>
> Absolutely, I'll give it a try and report back.

Looks good:

$ sudo bpftrace -e 'kprobe:__bond_xmit_hash { @skbs[pid] = arg1 }
kretprobe:__bond_xmit_hash { $skb_ptr = @skbs[pid]; if ($skb_ptr) {
$skb = (struct sk_buff *) $skb_ptr; $ipheader = ((struct iphdr *)
($skb->head + $skb->network_header)); printf("%s %x\n",
ntop($ipheader->daddr), retval); } }' | fgrep --line-buffered
x.y.z.205
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b
x.y.z.205 215fec1b

Hope it lands into the 5.15 stable queue as well.