netdev - Re: [PATCH iproute2] dcb: app: Add missing "dcb app show dev X default-prio"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0758f5ce-2461-95c2-edc0-9a24e44671d3@gmail.com>
Date:   Tue, 18 Jan 2022 19:44:02 -0700
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Maksym Yaremchuk <maksymy@...dia.com>
Subject: Re: [PATCH iproute2] dcb: app: Add missing "dcb app show dev X
 default-prio"

On 1/18/22 4:36 AM, Petr Machata wrote:
> All the actual code exists, but we neglect to recognize "default-prio" as a
> CLI key for selection of what to show.
> 
> Reported-by: Maksym Yaremchuk <maksymy@...dia.com>
> Tested-by: Maksym Yaremchuk <maksymy@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
>  dcb/dcb_app.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/dcb/dcb_app.c b/dcb/dcb_app.c
> index 28f40614..54a95a07 100644
> --- a/dcb/dcb_app.c
> +++ b/dcb/dcb_app.c
> @@ -646,6 +646,8 @@ static int dcb_cmd_app_show(struct dcb *dcb, const char *dev, int argc, char **a
>  			goto out;
>  		} else if (matches(*argv, "ethtype-prio") == 0) {
>  			dcb_app_print_ethtype_prio(&tab);
> +		} else if (matches(*argv, "default-prio") == 0) {
> +			dcb_app_print_default_prio(&tab);
>  		} else if (matches(*argv, "dscp-prio") == 0) {
>  			dcb_app_print_dscp_prio(dcb, &tab);
>  		} else if (matches(*argv, "stream-port-prio") == 0) {

In general, we are not allowing more uses of matches(). I think this one
can be an exception for consistency with the other options, so really
just a heads up.