netdev - Re: [PATCH] dt-bindings: Improve phandle-array schemas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220119054831.wvizk2dg5oomvppe@pengutronix.de>
Date:   Wed, 19 Jan 2022 06:48:31 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-can@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: Improve phandle-array schemas

On 18.01.2022 19:50:38, Rob Herring wrote:
> The 'phandle-array' type is a bit ambiguous. It can be either just an
> array of phandles or an array of phandles plus args. Many schemas for
> phandle-array properties aren't clear in the schema which case applies
> though the description usually describes it.
> 
> The array of phandles case boils down to needing:
> 
> items:
>   maxItems: 1
> 
> The phandle plus args cases should typically take this form:
> 
> items:
>   - items:
>       - description: A phandle
>       - description: 1st arg cell
>       - description: 2nd arg cell
> 
> With this change, some examples need updating so that the bracketing of
> property values matches the schema.
> 
> Cc: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Cc: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> Cc: Vinod Koul <vkoul@...nel.org>
> Cc: Georgi Djakov <djakov@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Marc Zyngier <maz@...nel.org>
> Cc: Joerg Roedel <joro@...tes.org>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Daniel Thompson <daniel.thompson@...aro.org>
> Cc: Jingoo Han <jingoohan1@...il.com>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Wolfgang Grandegger <wg@...ndegger.com>
> Cc: Marc Kleine-Budde <mkl@...gutronix.de>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Vivien Didelot <vivien.didelot@...il.com>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Vladimir Oltean <olteanv@...il.com>
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: Viresh Kumar <vireshk@...nel.org>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Kevin Hilman <khilman@...nel.org>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Jonathan Hunter <jonathanh@...dia.com>
> Cc: Sudeep Holla <sudeep.holla@....com>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: linux-ide@...r.kernel.org
> Cc: linux-crypto@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: dmaengine@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> Cc: iommu@...ts.linux-foundation.org
> Cc: linux-leds@...r.kernel.org
> Cc: linux-media@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Cc: linux-can@...r.kernel.org
> Cc: linux-wireless@...r.kernel.org
> Cc: linux-phy@...ts.infradead.org
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-riscv@...ts.infradead.org
> Cc: linux-remoteproc@...r.kernel.org
> Cc: alsa-devel@...a-project.org
> Cc: linux-usb@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
[...]
>  .../bindings/net/can/bosch,c_can.yaml         |  8 +-
>  .../bindings/net/can/fsl,flexcan.yaml         | 12 +--

For the net/can/ bindings:
Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)