lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Jan 2022 09:12:00 +0000 From: David Laight <David.Laight@...LAB.COM> To: 'Petr Mladek' <pmladek@...e.com>, Jani Nikula <jani.nikula@...ux.intel.com> CC: Lucas De Marchi <lucas.demarchi@...el.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>, "linux-security-module@...r.kernel.org" <linux-security-module@...r.kernel.org>, "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Alex Deucher <alexander.deucher@....com>, "Andrew Morton" <akpm@...ux-foundation.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Andy Shevchenko <andy.shevchenko@...il.com>, Ben Skeggs <bskeggs@...hat.com>, Christian König <christian.koenig@....com>, Chris Wilson <chris@...is-wilson.co.uk>, Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...ux.ie>, "David S . Miller" <davem@...emloft.net>, Emma Anholt <emma@...olt.net>, Eryk Brol <eryk.brol@....com>, Francis Laniel <laniel_francis@...vacyrequired.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Harry Wentland <harry.wentland@....com>, "Jakub Kicinski" <kuba@...nel.org>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Julia Lawall <julia.lawall@...6.fr>, Kentaro Takeda <takedakn@...data.co.jp>, Leo Li <sunpeng.li@....com>, "Mikita Lipski" <mikita.lipski@....com>, Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>, Raju Rangoju <rajur@...lsio.com>, "Rasmus Villemoes" <linux@...musvillemoes.dk>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Sergey Senozhatsky <sergey.senozhatsky@...il.com>, Steven Rostedt <rostedt@...dmis.org>, "Vishal Kulkarni" <vishal@...lsio.com> Subject: RE: [PATCH 0/3] lib/string_helpers: Add a few string helpers ... > Yeah, and I am sorry for bikeshedding. Honestly, I do not know what is > better. This is why I do not want to block this series when others > like this. > > My main motivation is to point out that: > > enabledisable(enable) > > might be, for some people, more eye bleeding than > > enable ? "enable" : "disable" Indeed - you need to look the former up, wasting brain time. > The problem is not that visible with yesno() and onoff(). But as you said, > onoff() confliscts with variable names. And enabledisable() sucks. > As a result, there is a non-trivial risk of two mass changes: > > now: > > - contition ? "yes" : "no" > + yesno(condition) > > a few moths later: > > - yesno(condition) > + str_yes_no(condition) Followed by: - str_yes_no(x) + no_yes_str(x) David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
Powered by blists - more mailing lists