netdev - RE: [PATCH net 1/5] i40e: Increase delay to 1 s after global EMP reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Jan 2022 10:13:26 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Tony Nguyen' <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     Jedrzej Jagielski <jedrzej.jagielski@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
        Gurucharan G <gurucharanx.g@...el.com>
Subject: RE: [PATCH net 1/5] i40e: Increase delay to 1 s after global EMP
 reset

From: Tony Nguyen
> Sent: 21 January 2022 00:03
> 
> Recently simplified i40e_rebuild causes that FW sometimes
> is not ready after NVM update, the ping does not return.
> 
> Increase the delay in case of EMP reset.
> Old delay of 300 ms was introduced for specific cards for 710 series.
> Now it works for all the cards and delay was increased.
...
> +	if (test_and_clear_bit(__I40E_EMP_RESET_INTR_RECEIVED, pf->state)) {
> +		/* The following delay is necessary for firmware update. */
> +		mdelay(1000);
>  	}

Spinning for a second isn't 'user friendly'.
If there are no locks held you can sleep.
If there are locks held then another cpu can spin waiting for the lock.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)