netdev - Re: [PATCH net-next v4 11/11] net: dsa: realtek: rtl8365mb: multiple cpu ports, non cpu extint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Jan 2022 19:22:27 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Alvin Šipraga <ALSI@...g-olufsen.dk>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "arinc.unal@...nc9.com" <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next v4 11/11] net: dsa: realtek: rtl8365mb: multiple
 cpu ports, non cpu extint



On 1/20/2022 7:13 PM, Luiz Angelo Daros de Luca wrote:
>> :) device tree properties are not the fix for everything!
> 
> I'm still getting used to it ;-)
> 
> In this thread, Alvin suggested adding a new property to define which
> port will be used as trap_port instead of using the last CPU port.
> Should I try something different?
> 
>          switch1 {
>                 compatible = "realtek,rtl8367s";
>                 reg = <29>;
> 
>                 realtek,trap-port = <&port7>;
> 
>                 ports {
>                          ....
>                          port7: port@7 {
>                              ...
>                         };
>          };
> 
> Should I do something differently?
> 
>> I think I know what the problem is. But I'd need to know what the driver
>> for the DSA master is, to confirm. To be precise, what I'd like to check
>> is the value of master->vlan_features.
> 
> Here it is 0x1099513266227 (I hope). Oh, this DSA driver still does
> not implement vlan nor bridge offload. Maybe it would matter.

Are we talking about an in tree driver? If so which is it?
-- 
Florian