netdev - Re: [PATCH net-next v4 05/11] net: dsa: realtek: use phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YetGa0hVM4J/DnxV@lunn.ch>
Date:   Sat, 22 Jan 2022 00:48:59 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Arınç ÜNAL <arinc.unal@...nc9.com>,
        Frank Wunderlich <frank-w@...lic-files.de>
Subject: Re: [PATCH net-next v4 05/11] net: dsa: realtek: use phy_read in
 ds->ops

> Should I submit a patch to make dsa work like this then?
> 
> dsa_switch_setup() {
>         ....
>         ds->ops->setup()
>         ....
>         if (ds->ops->phy_read) {
>               if (ds->slave_mii_bus)
>                     error("ds->ops->phy_read is set, I should be the
> one allocating ds->slave_mii_bus!")
>               ...allocate and register ds->slave_mii_bus...
>         }
> }

You could add a WARN_ON(ds->ops->phy_read && ds->ops->phy_read);

    Andrew