lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 23 Jan 2022 16:48:19 +0300
From:   Pavel Skripkin <>
To:     Dongliang Mu <>
Cc:     Dongliang Mu <>,
        Wolfgang Grandegger <>,
        Marc Kleine-Budde <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Stephane Grosjean <>,
        Stefan Mätje <>,
        Vincent Mailhol <>,,
        "open list:NETWORKING [GENERAL]" <>,
        linux-kernel <>
Subject: Re: [PATCH] drivers: net: remove a dangling pointer in

Hi Dongliang,

On 1/22/22 09:45, Dongliang Mu wrote:

>> Yeah, it seems like (at least based on code), that this dangling pointer
>> is not dangerous, since nothing accesses it. And next_siblings
>> _guaranteed_ to be NULL, since dev->next_siblings is set NULL in
>> disconnect()
> Yes, you're right. As a security researcher, I am sensitive to such
> dangling pointers.
> As its nullifying site is across functions, I suggest developers
> remove this dangling pointer in case that any newly added code in this
> function or before the nullifying location would touch next_siblings.

Based on git blame this driver is very old (was added in 2012), so, I 
guess, nothing really new will come up.

Anyway, I am absolutely not a security person and if you think, that 
this dangling pointer can be somehow used in exploitation you should 
state it in commit message.

> If Pavel and others think it's fine, then it's time to close this patch.

I don't have any big objections on the code itself. Maybe only 'if' can 
be removed to just speed up the code, but I don't see why this change is 
needed :)

With regards,
Pavel Skripkin

Powered by blists - more mailing lists