netdev - RE: [PATCH] net: fec_ptp: remove redundant initialization of variable val

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8PR04MB67955FA78F866E7B95B33207E65E9@DB8PR04MB6795.eurprd04.prod.outlook.com>
Date:   Mon, 24 Jan 2022 06:34:53 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Colin Ian King <colin.i.king@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] net: fec_ptp: remove redundant initialization of variable
 val


> -----Original Message-----
> From: Colin Ian King <colin.i.king@...il.com>
> Sent: 2022年1月24日 2:50
> To: Joakim Zhang <qiangqing.zhang@....com>; David S . Miller
> <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>;
> netdev@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] net: fec_ptp: remove redundant initialization of variable val
> 
> Variable val is being initialized with a value that is never read, it is being
> re-assigned later. The assignment is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Looks good for me, so

Reviewed-by: Joakim Zhang <qiangqing.zhang@....com>

Best Regards,
Joakim Zhang
> ---
>  drivers/net/ethernet/freescale/fec_ptp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index af99017a5453..7d49c28215f3 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -101,7 +101,6 @@ static int fec_ptp_enable_pps(struct
> fec_enet_private *fep, uint enable)
>  	u32 val, tempval;
>  	struct timespec64 ts;
>  	u64 ns;
> -	val = 0;
> 
>  	if (fep->pps_enable == enable)
>  		return 0;
> --
> 2.33.1