netdev - Re: [PATCH ethtool-next v2] features: add --json support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220124110249.47b5d504@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 24 Jan 2022 11:02:49 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Denys Fedoryshchenko <denys.f@...labora.com>
Cc:     Michal Kubecek <mkubecek@...e.cz>, netdev@...r.kernel.org
Subject: Re: [PATCH ethtool-next v2] features: add --json support

On Mon, 24 Jan 2022 10:06:35 +0200 Denys Fedoryshchenko wrote:
> +			if (is_json_context()) {
> +				print_bool(PRINT_JSON, off_flag_def[i].long_name, NULL, flag_value);
> +			} else {

Would it make sense to report "fixed" and "requested" as nil for the
special features? I'm not a high level language expert but otherwise
generic code handling features will have to test for presence of those
keys before accessing them, no?