lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Jan 2022 09:59:32 +0100 From: Magnus Karlsson <magnus.karlsson@...il.com> To: Maciej Fijalkowski <maciej.fijalkowski@...el.com> Cc: bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Network Development <netdev@...r.kernel.org>, "Karlsson, Magnus" <magnus.karlsson@...el.com>, Alexander Lobakin <alexandr.lobakin@...el.com> Subject: Re: [PATCH bpf-next v4 1/8] ice: remove likely for napi_complete_done On Mon, Jan 24, 2022 at 8:38 PM Maciej Fijalkowski <maciej.fijalkowski@...el.com> wrote: > > Remove the likely before napi_complete_done as this is the unlikely case > when busy-poll is used. Removing this has a positive performance impact > for busy-poll and no negative impact to the regular case. Acked-by: Magnus Karlsson <magnus.karlsson@...el.com> > Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com> > --- > drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c > index 3e38695f1c9d..e661d0e45b9b 100644 > --- a/drivers/net/ethernet/intel/ice/ice_txrx.c > +++ b/drivers/net/ethernet/intel/ice/ice_txrx.c > @@ -1513,7 +1513,7 @@ int ice_napi_poll(struct napi_struct *napi, int budget) > /* Exit the polling mode, but don't re-enable interrupts if stack might > * poll us due to busy-polling > */ > - if (likely(napi_complete_done(napi, work_done))) { > + if (napi_complete_done(napi, work_done)) { > ice_net_dim(q_vector); > ice_enable_interrupt(q_vector); > } else { > -- > 2.33.1 >
Powered by blists - more mailing lists