| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Jan 2022 11:29:03 +0100
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Mark Brown <broonie@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jarkko Sakkinen <jarkko@...nel.org>,
Peter Huewe <peterhuewe@....de>,
Jason Gunthorpe <jgg@...pe.ca>,
Benson Leung <bleung@...omium.org>,
Guenter Roeck <linux@...ck-us.net>
Cc: Andrew Lunn <andrew@...n.ch>,
Gwendal Grignou <gwendal@...omium.org>,
Yasunari Takiguchi <Yasunari.Takiguchi@...y.com>,
Claudius Heine <ch@...x.de>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Nanyong Sun <sunnanyong@...wei.com>,
Linus Walleij <linus.walleij@...aro.org>,
dri-devel@...ts.freedesktop.org, Jaroslav Kysela <perex@...ex.cz>,
Frieder Schrempf <frieder.schrempf@...tron.de>,
Pavel Machek <pavel@....cz>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Christian Lamparter <chunkeey@...glemail.com>,
Ajay Singh <ajay.kathat@...rochip.com>,
linux-clk@...r.kernel.org,
Stefan Schmidt <stefan@...enfreihafen.org>,
Sidong Yang <realwakka@...il.com>,
libertas-dev@...ts.infradead.org, linux-omap@...r.kernel.org,
Antti Palosaari <crope@....fi>,
Jean Delvare <jdelvare@...e.com>, linux-serial@...r.kernel.org,
Łukasz Stelmach <l.stelmach@...sung.com>,
Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>,
James Schulman <james.schulman@...rus.com>,
Kamlesh Gurudasani <kamlesh.gurudasani@...il.com>,
Jingoo Han <jingoohan1@...il.com>,
Zhang Qilong <zhangqilong3@...wei.com>,
Randy Dunlap <rdunlap@...radead.org>,
linux-stm32@...md-mailman.stormreply.com,
linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
Michael Walle <michael@...le.cc>,
Noralf Trønnes <noralf@...nnes.org>,
kernel@...gutronix.de, linux-mtd@...ts.infradead.org,
Andrew Morton <akpm@...ux-foundation.org>,
Vladimir Oltean <olteanv@...il.com>,
linux-wpan@...r.kernel.org,
Claudiu Beznea <claudiu.beznea@...rochip.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Dan Robertson <dan@...obertson.com>,
Markuss Broks <markuss.broks@...il.com>,
Lucas Tanure <tanureal@...nsource.cirrus.com>,
David Airlie <airlied@...ux.ie>,
linux-wireless@...r.kernel.org,
David Rhodes <david.rhodes@...rus.com>,
Thierry Reding <thierry.reding@...il.com>,
Solomon Peachy <pizza@...ftnet.org>,
Marek Behún <kabel@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>,
Jiri Slaby <jirislaby@...nel.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Tudor Ambarus <tudor.ambarus@...rochip.com>,
Minghao Chi <chi.minghao@....com.cn>,
Jon Hunter <jonathanh@...dia.com>,
dingsenjie <dingsenjie@...ong.com>, Heiko Schocher <hs@...x.de>,
Wolfgang Grandegger <wg@...ndegger.com>,
Matt Kline <matt@...bashing.io>,
Woojung Huh <woojung.huh@...rochip.com>,
Charles Keepax <ckeepax@...nsource.cirrus.com>,
Michael Hennerich <Michael.Hennerich@...log.com>,
Mike Looijmans <mike.looijmans@...ic.nl>,
Ronald Tschalär <ronald@...ovation.ch>,
Daniel Thompson <daniel.thompson@...aro.org>,
Maxime Ripard <mripard@...nel.org>, linux-can@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Hans de Goede <hdegoede@...hat.com>,
Stephen Boyd <sboyd@...nel.org>,
Davidlohr Bueso <dbueso@...e.de>, UNGLinuxDriver@...rochip.com,
linux-usb@...r.kernel.org,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
linux-integrity@...r.kernel.org,
Jonathan Cameron <jic23@...nel.org>,
Heiner Kallweit <hkallweit1@...il.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
linux-staging@...ts.linux.dev, linux-iio@...r.kernel.org,
Michael Turquette <mturquette@...libre.com>,
alsa-devel@...a-project.org,
Nuno Sá <nuno.sa@...log.com>,
netdev@...r.kernel.org, Wei Yongjun <weiyongjun1@...wei.com>,
Sam Ravnborg <sam@...nborg.org>,
Jérôme Pouiller <jerome.pouiller@...abs.com>,
linux-rtc@...r.kernel.org,
Marcus Folkesson <marcus.folkesson@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Aditya Srivastava <yashsri421@...il.com>,
Varka Bhadram <varkabhadram@...il.com>,
wengjianfeng <wengjianfeng@...ong.com>,
linux-input@...r.kernel.org, linux-media@...r.kernel.org,
Arnd Bergmann <arnd@...db.de>,
Jonathan Neuschäfer <j.neuschaefer@....net>,
Mark Greer <mgreer@...malcreek.com>,
Mark Gross <markgross@...nel.org>,
Richard Fitzgerald <rf@...nsource.cirrus.com>,
linux-fbdev@...r.kernel.org,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Stefan Mätje <stefan.maetje@....eu>,
linux-hwmon@...r.kernel.org, Felipe Balbi <balbi@...nel.org>,
Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>,
Support Opensource <support.opensource@...semi.com>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
linux-mmc@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
Julia Lawall <Julia.Lawall@...ia.fr>,
Yang Li <yang.lee@...ux.alibaba.com>,
Dan Carpenter <dan.carpenter@...cle.com>,
patches@...nsource.cirrus.com, Kent Gustavsson <kent@...oris.se>,
"David S. Miller" <davem@...emloft.net>,
Alexander Aring <alex.aring@...il.com>,
Jiri Prchal <jiri.prchal@...ignal.cz>,
Vignesh Raghavendra <vigneshr@...com>,
Emma Anholt <emma@...olt.net>,
Peter Zijlstra <peterz@...radead.org>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Alexandru Ardelean <ardeleanalex@...il.com>,
Antoniu Miclaus <antoniu.miclaus@...log.com>,
Torin Cooper-Bennun <torin@...iluxsystems.com>,
Lee Jones <lee.jones@...aro.org>, linux-leds@...r.kernel.org,
Eric Piel <eric.piel@...mplin-utc.net>,
Stephan Gerhold <stephan@...hold.net>,
Richard Weinberger <richard@....at>,
Russell King <linux@...linux.org.uk>,
Thomas Kopp <thomas.kopp@...rochip.com>,
Jakub Kicinski <kuba@...nel.org>,
Vivien Didelot <vivien.didelot@...il.com>,
platform-driver-x86@...r.kernel.org,
Stefan Wahren <stefan.wahren@...e.com>,
Xue Liu <liuxuenetmail@...il.com>,
David Lechner <david@...hnology.com>,
Will Deacon <will@...nel.org>,
Manivannan Sadhasivam <mani@...nel.org>,
Kalle Valo <kvalo@...nel.org>,
Rui Miguel Silva <rmfrfs@...il.com>,
Marc Kleine-Budde <mkl@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Vincent Mailhol <mailhol.vincent@...adoo.fr>,
Alessandro Zummo <a.zummo@...ertech.it>,
Yang Shen <shenyang39@...wei.com>,
Thomas Zimmermann <tzimmermann@...e.de>,
Takashi Iwai <tiwai@...e.com>,
Cai Huoqing <caihuoqing@...du.com>,
Daniel Mack <daniel@...que.org>,
Daniel Vetter <daniel@...ll.ch>,
Colin Ian King <colin.king@...el.com>,
Helge Deller <deller@....de>, Alan Ott <alan@...nal11.us>
Subject: Re: [PATCH 5/5] spi: make remove callback a void function
[Dropped a few people from Cc that are not reachable (Harry Morris,
Charles-Antoine Couret, Marco Felsch)]
On Tue, Jan 25, 2022 at 09:47:59AM +0000, Jonathan Cameron wrote:
> On Sun, 23 Jan 2022 18:52:01 +0100
> Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:
>
> > The value returned by an spi driver's remove function is mostly ignored.
> > (Only an error message is printed if the value is non-zero that the
> > error is ignored.)
> >
> > So change the prototype of the remove function to return no value. This
> > way driver authors are not tempted to assume that passing an error to
> > the upper layer is a good idea. All drivers are adapted accordingly.
> > There is no intended change of behaviour, all callbacks were prepared to
> > return 0 before.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> For iio drivers.
>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>
> As you mention in the cover letter we'll be wanting an immutable
> branch somewhere to pull into subsystem trees.
>
> Soon is good if possible as otherwise we'll end up with a bunch of merge
> conflicts getting resolved in next.
Yes, I considered creating a tag to pull already when sending out this
series, but I guessed delaying that a little bit to give people the
opportunity to ack would be a good idea.
@broonie: Do you think this change is a good idea? Would you require
some more acks for the preparatory patches? I had hoped to get Acks from
the corresponding maintainers, maybe they are busy and missed this
series as I put them on Cc: only. I promoted them to To: in this mail.
Or is it too ambitious to get this in during the next merge window?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists